[PATCH] D148230: ValueTracking: fadd +0 cannot return -0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4369
+    if (KnownRHS.KnownFPClasses == fcPosZero && Op->getOpcode() == Instruction::FAdd)
+      Known.knownNot(fcNegZero);
+
----------------
kpn wrote:
> We're in the default FP environment here since we're looking at FAdd and FSub instructions. The check for FAdd isn't needed?
I was just copying from CannotBeNegativeZero but I guess we can improve on it at the same time 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148230/new/

https://reviews.llvm.org/D148230