[PATCH] D147936: ValueTracking: Handle minimum/maximum in computeKnownFPClass

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 07:23:40 PDT 2023


kpn added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4498
+                            Known2, Depth + 1, Q, TLI);
+        Known |= Known2;
+        break;
----------------
Is this correct? If we know that one operand cannot be NaN, but we don't know that about the other operand, then we can't know if the result of the operation is NaN or not. This is llvm.minimum/llvm.maximum, correct? Those are documented as propagating NaN,


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147936/new/

https://reviews.llvm.org/D147936



More information about the llvm-commits mailing list