[PATCH] D148208: [llvm-readobj] fix unit test failure on 32bit machines

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 05:39:28 PDT 2023


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/AArch64/memtag.test:309
 
+# RUN: yaml2obj --docnum=3 %s -o %t \
+# RUN:   -D DT_AARCH64_MEMTAG_GLOBALSSZ=0x100000001 \
----------------
Can you confirm tha this test case fails if using a 32-bit machine without your fix?

Also, please add a small comment explaining that this is to show that the GLOBALSSZ tag is stored in a 64-bit integer even on 32-bit machines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148208/new/

https://reviews.llvm.org/D148208



More information about the llvm-commits mailing list