[PATCH] D148171: ValueTracking: Implement computeKnownFPClass for fdiv for nan/inf handling

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 05:31:32 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4393
+  case Instruction::FDiv: {
+    const bool WantInfNan = (InterestedClasses & (fcInf | fcNan)) != fcNone;
+    if (!WantInfNan)
----------------
After the other fixes we are no longer interested in fcInf here.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4408
+
+    if (KnowSomethingUseful && WantInfNan) {
+      computeKnownFPClass(Op->getOperand(0), DemandedElts,
----------------
WantInfNan is always true here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148171/new/

https://reviews.llvm.org/D148171



More information about the llvm-commits mailing list