[PATCH] D148212: [Assignment Tracking][SelectionDAG] Downgrade dbg.assigns to dbg.values if assignment tracking is not enabled

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added inline comments.


================
Comment at: llvm/test/DebugInfo/assignment-tracking/X86/assignment-tracking-not-enabled.ll:1-2
+; RUN: llc %s -stop-after=finalize-isel -o - \
+; RUN: | FileCheck %s --implicit-check-not=DBG_
+
----------------
jmorse wrote:
> I think the triple needs to present on the command line or in the ll file, otherwise we'll hit buildbots that support x86 but where it isn't the default triple, and we'll get different output.
Good spot, thanks.


================
Comment at: llvm/test/DebugInfo/assignment-tracking/X86/assignment-tracking-not-enabled.ll:4-6
+;; Check that SelectionDAG downgrades dbg.assigns to dbg.values if assignment
+;; tracking isn't enabled (e.g. if the module flag
+;; "debug-info-assignment-tracking" is missing / false).
----------------
jmorse wrote:
> What would the debug-info output look like with AT, and do we need to CHECK-NOT it?
The variable would be stuffed into the side-table since it is always stack-homed. I will add some CHECK-NOTs for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148212/new/

https://reviews.llvm.org/D148212