[PATCH] D147544: [BOLT] Move from RuntimeDyld to JITLink

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 13 03:30:30 PDT 2023


jobnoorman updated this revision to Diff 513153.
jobnoorman added a comment.

Fix memory leak reported by ASan.

The .debug_line_str section wasn't processed by RuntimeDyld before. Since
JITLink would err without it, this patch modified BOLT to allocate it using the
JIT memory manager. However, it was also still manually allocated by
DwarfLineTable, ultimately resulting in a memory leak. This updates makes sure
.debug_line_str is *only* allocated by the memory manager.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147544/new/

https://reviews.llvm.org/D147544

Files:
  bolt/include/bolt/Core/BinaryContext.h
  bolt/include/bolt/Core/BinarySection.h
  bolt/include/bolt/Core/Linker.h
  bolt/include/bolt/Rewrite/ExecutableFileMemoryManager.h
  bolt/include/bolt/Rewrite/JITLinkLinker.h
  bolt/include/bolt/Rewrite/MachORewriteInstance.h
  bolt/include/bolt/Rewrite/RewriteInstance.h
  bolt/include/bolt/RuntimeLibs/HugifyRuntimeLibrary.h
  bolt/include/bolt/RuntimeLibs/InstrumentationRuntimeLibrary.h
  bolt/include/bolt/RuntimeLibs/RuntimeLibrary.h
  bolt/lib/Core/BinaryContext.cpp
  bolt/lib/Core/BinaryEmitter.cpp
  bolt/lib/Core/DebugData.cpp
  bolt/lib/Rewrite/CMakeLists.txt
  bolt/lib/Rewrite/ExecutableFileMemoryManager.cpp
  bolt/lib/Rewrite/JITLinkLinker.cpp
  bolt/lib/Rewrite/MachORewriteInstance.cpp
  bolt/lib/Rewrite/RewriteInstance.cpp
  bolt/lib/RuntimeLibs/CMakeLists.txt
  bolt/lib/RuntimeLibs/HugifyRuntimeLibrary.cpp
  bolt/lib/RuntimeLibs/InstrumentationRuntimeLibrary.cpp
  bolt/lib/RuntimeLibs/RuntimeLibrary.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147544.513153.patch
Type: text/x-patch
Size: 57162 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230413/b5b7821e/attachment.bin>


More information about the llvm-commits mailing list