[PATCH] D148079: [llvm-exegesis] Refactor common parts out of FunctionExecutorImpl

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet accepted this revision.
gchatelet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:96-97
+  protected:
+    static void accumulateCounterValues(const llvm::SmallVectorImpl<int64_t> &,
+                                        llvm::SmallVectorImpl<int64_t> *);
     virtual Expected<llvm::SmallVector<int64_t, 4>>
----------------
The parameters should be named


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148079/new/

https://reviews.llvm.org/D148079