[PATCH] D147864: ValueTracking: Address todo for nan fmul handling in computeKnownFPClass

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4468
     KnownFPClass KnownLHS, KnownRHS;
-    computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan | fcInf,
+    computeKnownFPClass(Op->getOperand(1), DemandedElts, fcNan | fcInf | fcZero,
                         KnownRHS, Depth + 1, Q, TLI);
----------------
arsenm wrote:
> nikic wrote:
> > Don't we also need to pass in fcSubnormal as well for these?
> It's not strictly necessary since we're not really making use of these hints yet 
Even if it's not used yet, we should include it so it continues working in the future... Or just drop the argument entirely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147864/new/

https://reviews.llvm.org/D147864