[PATCH] D148196: [SelectionDAG] Rename ADDCARRY/SUBCARRY to UADDO_CARRY/USUBO_CARRY

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

> ADDCARRY/SUBCARRY have been the only overflow-aware nodes for a long time.

UADDO and USUBO are much older than ADDCARRY/SUBCARRY.



================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:301
+  /// These opcodes are different from S{ADD,SUB}O_CARRY in that
+  /// U{ADD,SUB}O_CARRY produce a carry/borrow, whereas S{ADD,SUB}O_CARRY
+  /// produce an overflow.
----------------
I think too many things got renamed here. The comparison to [US]{ADD,SUB}O matches the rest of the description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148196/new/

https://reviews.llvm.org/D148196