[PATCH] D148126: [llvm][readobj] Add AArch64 SME and SME2 note types

Thu Apr 13 00:27:23 PDT 2023

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one query.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5743
+    {ELF::NT_ARM_PAC_MASK,
+     "NT_ARM_PAC_MASK (AArch64 Pointer Authentication code mask registers)"},
+    {ELF::NT_ARM_SSVE, "NT_ARM_SSVE (AArch64 Streaming SVE registers)"},
----------------
In the Linux elf.h, this is labelled as "ARM pointer authentication code masks" which doesn't mention registers. I don't know enough about this to know whether or not it's just missing the word though, so it's fine if nothing needs to change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148126/new/

https://reviews.llvm.org/D148126