[PATCH] D147931: [ARM] Fix null pointer dereferences in ARMMachObjectWriter::recordRelocation()

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 23:55:10 PDT 2023


dmgreen added a comment.

If you wanted to add an assert or change the condition of the `if (Target.isAbsolute())` to `if (!A)` then I wouldn't be against it, providing there was a comment to explain that meant isAbsolute. But yes, this looks like a false positive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147931/new/

https://reviews.llvm.org/D147931



More information about the llvm-commits mailing list