[PATCH] D146780: [AArch64][GlobalISel] Selection support for v8s8, v4s16, v16s8 G_INSERT_VECTOR_ELT with GPR scalar

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 21:15:21 PDT 2023


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

Sorry, missed this. LGTM.



================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:5376
+  if (EltSize < 8 || EltSize > 64)
     return false; // Don't support all element types yet.
 
----------------
This comment is obsolete now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146780/new/

https://reviews.llvm.org/D146780



More information about the llvm-commits mailing list