[PATCH] D146854: [Symbolizer] Add flag to dump symbolizer markup context JSON.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D146854#4228721 <https://reviews.llvm.org/D146854#4228721>, @mysterymath wrote:

> In D146854#4227650 <https://reviews.llvm.org/D146854#4227650>, @dblaikie wrote:
>
>> "context" as the name for this confuses me a bit - perhaps you can describe it more (maybe I'm jus tthinking about it wrong, or maybe it could benefit from a rename)
>>
>> When I think of "dumping context" - I think of dumping the text surrounding the symbolizer markup, which it isn't doing. It looks like it's something like "dump markup as json", is that accurate? (& it drops/doesn't print out any of the non-markup content present in the input?)
>
> The term "context" comes from the symbolizer markup format: https://llvm.org/docs/SymbolizerMarkupFormat.html#contextual-elements
> In this case it's not actually dumping the presentation requests from the markup, it's dumping a completed representation of the process layout contained in the "contextual elements" of the markup. These contextualize virtual addresses to allow symbolizing them later; and it's that contextual information that it'd be useful to export and import into other tools.

I have the same confusion as well. If there are most significant contextual elements, can their names be mentioned in the help message of `--dump-context`? Just mentioning the element name should still make the message brief.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146854/new/

https://reviews.llvm.org/D146854