[PATCH] D147285: [Support] Extended llvm-profdata's merge functionality to exclude profiles from functions matching configurable patterns

[NILANJANA BASU via Phabricator via llvm-commits]

nilanjana_basu added inline comments.


================
Comment at: llvm/test/tools/llvm-profdata/merge-filtering.test:57
+# excluding profile for one pattern matching multiple functions
+RUN: llvm-profdata merge --exclude-function "foo" --text %p/Inputs/basic.proftext -o - | FileCheck %s --check-prefix=MERGE-EXCL-SINGLE-PAT
+MERGE-EXCL-SINGLE-PAT-NOT: foo
----------------
paquette wrote:
> I'd expect the regular expression here to be something like `foo.*`, not `foo`?
Added new cases for regex. 


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:345
+
+    if (ToBeExcluded) {
+      continue;
----------------
paquette wrote:
> clang-format should remove these braces
It didn't, but I removed it manually.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147285/new/

https://reviews.llvm.org/D147285