[PATCH] D148049: [llvm-objdump] Add --markup-context to adjust VMAs.

Daniel Thornburgh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 15:50:31 PDT 2023


mysterymath added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/markup-context.test:48
+
+# MISSING-FILE: error: '{{.*}}missing.json': No such file or directory
+# INVALID-JSON: error: '{{.*}}invalid.json': [2:0, byte=2]: Expected object key
----------------
jhenderson wrote:
> This will fail on various OSes. You should use the %errc... substitutions to get the platform-specific message. You'll need to pass them in as FileCheck variables.
Ah thanks, TIL!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148049/new/

https://reviews.llvm.org/D148049



More information about the llvm-commits mailing list