[PATCH] D147900: [ValueTracking] Use `select` condition to help determine if `select` is non-zero

Wed Apr 12 13:29:06 PDT 2023

goldstein.w.n added a comment.

In D147900#4262795 <https://reviews.llvm.org/D147900#4262795>, @nikic wrote:

> In D147900#4262716 <https://reviews.llvm.org/D147900#4262716>, @nikic wrote:
>
>> Can you please base this on cmpExcludesZero() instead? I don't think there's need to handle cases here that we don't handle for assumes or branches.
>
> (I realized this might be ambiguous, so to clarify: What I mean is to use cmpExcludesZero() with its current set of supported functionality, **not** to generalize it to handle additional cases.)

Oh okay. Open to a future patch to expand `cmpExcludesZero`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147900/new/

https://reviews.llvm.org/D147900