[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

[Dimitry Andric via Phabricator via llvm-commits]

dim added a subscriber: mstorsjo.
dim added a comment.

So this seems to have been caused by @mstorsjo 's rG8368e4d54c459fe173d76277f17c632478e91add <https://reviews.llvm.org/rG8368e4d54c459fe173d76277f17c632478e91add>, which added:

  set(CMAKE_TRY_COMPILE_TARGET_TYPE STATIC_LIBRARY)

to `compiler-rt/lib/builtins/CMakeLists.txt`. Because this line is there, the checks in CMAKE_DETERMINE_COMPILER_ABI don't run the linker, and this CMake functionality needs to see linker output lines to determine the actual ABI, in this case `x86_64-linux-gnu`.

E.g. when configuring the runtimes, I eventually see in the cmake debug output:

  ...
  CMakeCCompiler.cmake(56):  if(CMAKE_C_LIBRARY_ARCHITECTURE )
  CMakeCCompiler.cmake(57):  set(CMAKE_LIBRARY_ARCHITECTURE x86_64-linux-gnu )
  CMakeCCompiler.cmake(60):  set(CMAKE_C_CL_SHOWINCLUDES_PREFIX  )
  ...

whereas with the builtins, this variable stays empty:

  ...
  CMakeCCompiler.cmake(56):  if(CMAKE_C_LIBRARY_ARCHITECTURE )
  CMakeCCompiler.cmake(60):  set(CMAKE_C_CL_SHOWINCLUDES_PREFIX  )
  ...

Because `CMAKE_LIBRARY_ARCHITECTURE` isn't set, the `find_library()` calls for e.g. zlib (but also other libraries) fail to search `/usr/lib/x86_64-linux-gnu` (or other ABI specific library paths).

In short, I think what @amyk saw is orthogonal to this review, and I would therefore like to commit it. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145884/new/

https://reviews.llvm.org/D145884