[PATCH] D146349: [InstCombine] Make `FoldOpIntoSelect` handle non-constants and use condition to deduce constants.

Wed Apr 12 12:59:05 PDT 2023

nikic added a comment.

In D146349#4262718 <https://reviews.llvm.org/D146349#4262718>, @goldstein.w.n wrote:

> In D146349#4262696 <https://reviews.llvm.org/D146349#4262696>, @nikic wrote:
>
>> This should also relax the requirement on at least one caller so that the change becomes testable. Or maybe you can use the one in InstCombineCalls to test this, I think one of the multi-argument intrinsics should work.
>
> Thats what happens in: D146350 <https://reviews.llvm.org/D146350>, do you want me to merge the two?

That patch does more than we need for this. It would be enough to relax any of the existing calls (or use the intrinsic one if it works).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146349/new/

https://reviews.llvm.org/D146349