[PATCH] D147939: ValueTracking: Handle fptrunc in computeKnownFPClass

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 12:38:56 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4627
+    if (KnownSrc.isKnownNeverNaN())
+      Known.knownNot(fcNan);
+    break;
----------------
kpn wrote:
> Isn't infinity an issue as well? If the input to be truncated is zero then we know the result can't be infinity. Then again, if the goal is to keep parity with the old implementation then do we need to worry about infinity yet?
fptrunc(inf) => inf so there isn't really an issue as much of a missing optimization 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147939/new/

https://reviews.llvm.org/D147939



More information about the llvm-commits mailing list