[PATCH] D147982: Account for PATCHABLE instrs in Branch Relaxation
Daniel Hoekwater via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 12 12:19:16 PDT 2023
dhoekwater added a comment.
Because `isMBBSafeToOutlineFrom` already accounted for `TargetOpcode::FENTRY_CALL` and `TargetOpcode::PATCHABLE_FUNCTION_ENTER`, I won't be able to write a test that makes `PATCHABLE_FUNCTION_ENTER` outlined without this patch.
I //could// probably write a test that makes sure `TargetOpcode::PATCHABLE_RET` and `TargetOpcode::PATCHABLE_TAIL_CALL` aren't outlined, but neither of those instructions are inserted on AArch64 (they're only inserted on `ppc64le` and `x86_64`, respectively). AFAIK no test exists to make sure they aren't outlined.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147982/new/
https://reviews.llvm.org/D147982
More information about the llvm-commits
mailing list