[PATCH] D148133: [compiler-rt] [ubsan] Fix printing of floats in mingw mode
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 12 11:21:03 PDT 2023
mstorsjo added inline comments.
================
Comment at: compiler-rt/lib/ubsan/ubsan_diag.cpp:218
+ // On MSVC platforms, long doubles are equal to regular doubles.
+ // In mingw environments on x86, long doubles are 80 bit, but here,
+ // we're calling an MS CRT provided printf function which considers
----------------
MaskRay wrote:
> In comments we prefer more canonical spelling. MinGW seems more canonical and also more popular than mingw in comments?
Sure, I can change it that way, as that’s the canonical spelling.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148133/new/
https://reviews.llvm.org/D148133
More information about the llvm-commits
mailing list