[PATCH] D148150: [InstrProf][Temporal] Add weight field to traces

Ellis Hoag via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 11:07:25 PDT 2023


ellis created this revision.
ellis added reviewers: davidxl, snehasish.
Herald added subscribers: Enna1, hiraditya.
Herald added a project: All.
ellis edited the summary of this revision.
ellis published this revision for review.
Herald added projects: Sanitizers, LLVM.
Herald added subscribers: llvm-commits, Sanitizers.

As discussed in [0], add a `weight` field to temporal profiling traces found in profiles. This allows users to use the `--temporal-profile-trace-weight` flag in the `llvm-profdata merge` command to weight traces from different scenarios differently.

Note that this is a breaking change, but since [1] landed very recently and there is no way to "use" this trace data, there should be no users of this feature. We believe it is acceptable to land this change without bumping the profile format version.

[0] https://reviews.llvm.org/D147812#4259507
[1] https://reviews.llvm.org/D147287


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148150

Files:
  compiler-rt/test/profile/instrprof-timestamp.c
  llvm/docs/CommandGuide/llvm-profdata.rst
  llvm/include/llvm/ProfileData/InstrProf.h
  llvm/include/llvm/ProfileData/InstrProfReader.h
  llvm/lib/ProfileData/InstrProfReader.cpp
  llvm/lib/ProfileData/InstrProfWriter.cpp
  llvm/test/tools/llvm-profdata/merge-traces.proftext
  llvm/test/tools/llvm-profdata/read-traces.proftext
  llvm/test/tools/llvm-profdata/trace-limit.proftext
  llvm/tools/llvm-profdata/llvm-profdata.cpp
  llvm/unittests/ProfileData/InstrProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148150.512906.patch
Type: text/x-patch
Size: 20451 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230412/0a70d1c1/attachment.bin>


More information about the llvm-commits mailing list