[PATCH] D147694: [FunctionAttrs] Fix nounwind inference for landingpads

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 10:27:07 PDT 2023


efriedma added inline comments.


================
Comment at: llvm/lib/IR/Instruction.cpp:775
+      return canUnwindPastLandingPad(LP, IncludePhaseOneUnwind);
+    if (isa<CleanupPadInst>(Pad))
+      // Treat the same as cleanup landingpad.
----------------
The "pad" in the destination on Windows can be either a cleanuppad or a catchswitch; you might need to handle both cases? (Either that, or change the way catchswitch is handled.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147694/new/

https://reviews.llvm.org/D147694



More information about the llvm-commits mailing list