[PATCH] D148036: [SLP]Improve reduction cost model for scalars.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 09:42:30 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/test/Transforms/SLPVectorizer/X86/horizontal-smax.ll:37
+; AVX-NEXT:    [[TMP3:%.*]] = call i32 @llvm.vector.reduce.smax.v4i32(<4 x i32> [[TMP2]])
+; AVX-NEXT:    ret i32 [[TMP3]]
 ;
----------------
ABataev wrote:
> RKSimon wrote:
> > This looks to be about right: https://gcc.godbolt.org/z/sq99696Y7
> > 
> > You can add additional SSE test levels if you want to be certain?
> You mean add some extra tests for smin/umin/umax/fmin/fmax?
No - extra SSE test levels - I've added them at rG162284b2e1a970a01144d1d8e7f8d4fd1e03c5bf


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148036/new/

https://reviews.llvm.org/D148036



More information about the llvm-commits mailing list