[PATCH] D148054: [WebAssembly] `AsmTypeCheck` support to br instr

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/type-checker-errors.s:744
+    br 0
+  end_try
+  drop
----------------
aheejin wrote:
> `try`~`end_try` without a `catch`/`catch_all` is malformed.
Nit: I think `tag_f32` (as in my previous suggestion) is better, because `tag_i32` means introducing another type error within the `catch`. But we have another test for checking `catch` part below.


================
Comment at: llvm/test/MC/WebAssembly/type-checker-errors.s:772
+
+br_invalid_depth:
+  .functype br_invalid_depth () -> ()
----------------
aheejin wrote:
> Can we add a few more tests on the depth?
> 1. When the depth is +1 than the max possible depth (including the function boundary) (incorrect)
> 2. When the depth targets the function boundary (correct)
> 3. When the depth targets the function boundary, but the signature doesn't match (incorrect)
Ping. I don't think any of these were added?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148054/new/

https://reviews.llvm.org/D148054