[PATCH] D147172: [OpenMP][Flang][MLIR] Add lowering of TargetOp for host codegen

[Jan Sjödin via Phabricator via llvm-commits]

jsjodin added inline comments.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4180
+  // TODO: Add kernel launch call when device codegen is supported.
+  Builder.CreateCall(OutlinedFn, Args);
+}
----------------
jsjodin wrote:
> jdoerfert wrote:
> > FWIW, you should already (be able to) emit the kernel launch call and fallback handling.
> > The latter should kick in as the symbol is neither registered nor available on the device.
> > FWIW, you should already (be able to) emit the kernel launch call and fallback handling.
> > The latter should kick in as the symbol is neither registered nor available on the device.
> 
> Should I add the code to build the kernel args, or do you mean empty kernel args?
I forgot to mention that I am working on a patch to handle the kernel args which adds the kernel launch call. So I could pull that merge that patch into this or keep it separate. @kiranchandramohan, @jdoerfert  you have a preference?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147172/new/

https://reviews.llvm.org/D147172