[PATCH] D147752: [GuardUtils] Add asserts about loop varying widenable conditions

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 07:57:46 PDT 2023


anna added a comment.

Hitting this downstream. Assert maybe too strict.  Will revert for now and investigate.
During offline discussion with Artur, he had an idea to change the API completely from widening a *branch* to widening a *widenable condition* (i.e. rather than change one use of a widenable condition, we should change all uses). Also, this way, we will never run into change a loop-invariant condition to a loop-varying one (since we're widening at the widenable condition which has to be outside the loop for it to be loop-invariant in the first place).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147752/new/

https://reviews.llvm.org/D147752



More information about the llvm-commits mailing list