[PATCH] D147287: [InstrProf] Temporal Profiling

Wed Apr 12 07:53:19 PDT 2023

ellis added a comment.

In D147287#4261473 <https://reviews.llvm.org/D147287#4261473>, @hans wrote:

> This broke the profile tests on Darwin, see e.g. the end of https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8784035713603613281/+/u/package_clang/stdout
>
> It seems these tests are checking what symbols are exported by the runtime, and are surprised to find the new __llvm_profile_global_timestamp variable there.
>
> From what I can tell, that variable is only accessed inside the library, and making it static fixes the tests, so I'll go ahead and do that. Please revert if that doesn't seem right to you.

That seems fine to me. Thanks for fixing!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147287/new/

https://reviews.llvm.org/D147287