[llvm] fee3980 - [AMDGPU] Fix amdgpu_gfx tail-call test

[Sebastian Neubauer via llvm-commits]

Author: Sebastian Neubauer
Date: 2023-04-12T16:15:09+02:00
New Revision: fee3980df5c61888b54ad1c560fb8ffcd2d7ecdb

URL: https://github.com/llvm/llvm-project/commit/fee3980df5c61888b54ad1c560fb8ffcd2d7ecdb
DIFF: https://github.com/llvm/llvm-project/commit/fee3980df5c61888b54ad1c560fb8ffcd2d7ecdb.diff

LOG: [AMDGPU] Fix amdgpu_gfx tail-call test

The inreg argument prevented the tail call optimization to kick in.
Remove the inreg, so this test actually uses a tail call.

Note that it now uses s[4:5] for the return address, which is invalid,
because these registers are supposed to be callee-save.
D147096 tried to fix that problem for the C calling convention.

Differential Revision: https://reviews.llvm.org/D148119

Added: 
    

Modified: 
    llvm/test/CodeGen/AMDGPU/tail-call-amdgpu-gfx.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/AMDGPU/tail-call-amdgpu-gfx.ll b/llvm/test/CodeGen/AMDGPU/tail-call-amdgpu-gfx.ll
index e2aaa47c3c0b..4059d2d80f89 100644
--- a/llvm/test/CodeGen/AMDGPU/tail-call-amdgpu-gfx.ll
+++ b/llvm/test/CodeGen/AMDGPU/tail-call-amdgpu-gfx.ll
@@ -2,14 +2,17 @@
 ; RUN: llc -mtriple=amdgcn--amdpal -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -check-prefixes=GCN -enable-var-scope %s
 ; RUN: llc -global-isel -mtriple=amdgcn--amdpal -mcpu=gfx900 -verify-machineinstrs < %s | FileCheck -check-prefixes=GCN -enable-var-scope %s
 
-; Callee with SGPR and VGPR arguments
-define hidden amdgpu_gfx float @callee(float %v.arg0, float inreg %s.arg1) {
+; FIXME: @caller uses s[4:5] to store the address of @callee.
+;        These registers are callee-save in the amdgpu_gfx calling convention, so they must not be clobbered, but they are clobbered here.
+
+; Callee with VGPR arguments
+define hidden amdgpu_gfx float @callee(float %v.arg0, float %v.arg1) {
 ; GCN-LABEL: callee:
 ; GCN:       ; %bb.0:
 ; GCN-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
-; GCN-NEXT:    v_add_f32_e32 v0, s4, v0
+; GCN-NEXT:    v_add_f32_e32 v0, v0, v1
 ; GCN-NEXT:    s_setpc_b64 s[30:31]
-  %add = fadd float %v.arg0, %s.arg1
+  %add = fadd float %v.arg0, %v.arg1
   ret float %add
 }
 
@@ -17,32 +20,23 @@ define amdgpu_gfx float @caller(float %arg0) {
 ; GCN-LABEL: caller:
 ; GCN:       ; %bb.0:
 ; GCN-NEXT:    s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0)
-; GCN-NEXT:    s_mov_b32 s36, s33
-; GCN-NEXT:    s_mov_b32 s33, s32
 ; GCN-NEXT:    s_xor_saveexec_b64 s[34:35], -1
-; GCN-NEXT:    buffer_store_dword v1, off, s[0:3], s33 ; 4-byte Folded Spill
+; GCN-NEXT:    buffer_store_dword v2, off, s[0:3], s32 ; 4-byte Folded Spill
 ; GCN-NEXT:    s_mov_b64 exec, s[34:35]
-; GCN-NEXT:    v_writelane_b32 v1, s4, 0
-; GCN-NEXT:    s_addk_i32 s32, 0x400
-; GCN-NEXT:    v_writelane_b32 v1, s30, 1
+; GCN-NEXT:    v_writelane_b32 v2, s4, 0
+; GCN-NEXT:    v_writelane_b32 v2, s5, 1
+; GCN-NEXT:    s_getpc_b64 s[4:5]
+; GCN-NEXT:    s_add_u32 s4, s4, callee at rel32@lo+4
+; GCN-NEXT:    s_addc_u32 s5, s5, callee at rel32@hi+12
 ; GCN-NEXT:    v_add_f32_e32 v0, 1.0, v0
-; GCN-NEXT:    s_mov_b32 s4, 2.0
-; GCN-NEXT:    v_writelane_b32 v1, s31, 2
-; GCN-NEXT:    s_getpc_b64 s[34:35]
-; GCN-NEXT:    s_add_u32 s34, s34, callee at rel32@lo+4
-; GCN-NEXT:    s_addc_u32 s35, s35, callee at rel32@hi+12
-; GCN-NEXT:    s_swappc_b64 s[30:31], s[34:35]
-; GCN-NEXT:    v_readlane_b32 s31, v1, 2
-; GCN-NEXT:    v_readlane_b32 s30, v1, 1
-; GCN-NEXT:    v_readlane_b32 s4, v1, 0
+; GCN-NEXT:    v_mov_b32_e32 v1, 2.0
+; GCN-NEXT:    v_readlane_b32 s5, v2, 1
+; GCN-NEXT:    v_readlane_b32 s4, v2, 0
 ; GCN-NEXT:    s_xor_saveexec_b64 s[34:35], -1
-; GCN-NEXT:    buffer_load_dword v1, off, s[0:3], s33 ; 4-byte Folded Reload
+; GCN-NEXT:    buffer_load_dword v2, off, s[0:3], s32 ; 4-byte Folded Reload
 ; GCN-NEXT:    s_mov_b64 exec, s[34:35]
-; GCN-NEXT:    s_addk_i32 s32, 0xfc00
-; GCN-NEXT:    s_mov_b32 s33, s36
-; GCN-NEXT:    s_waitcnt vmcnt(0)
-; GCN-NEXT:    s_setpc_b64 s[30:31]
+; GCN-NEXT:    s_setpc_b64 s[4:5]
   %add = fadd float %arg0, 1.0
-  %call = tail call amdgpu_gfx float @callee(float %add, float inreg 2.0)
+  %call = tail call amdgpu_gfx float @callee(float %add, float 2.0)
   ret float %call
 }