[PATCH] D148071: [LoopUnroll] Prevent LoopFullUnrollPass to perform partial/runtime unrolling

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnroll/full-unroll-keep-first-exit.ll:3
 ; RUN: opt -S -passes=loop-unroll < %s | FileCheck %s
-; RUN: opt -S -passes='require<opt-remark-emit>,loop(loop-unroll-full)' < %s | FileCheck %s
 
----------------
nikic wrote:
> Can you please restore this check line, possibly with an additional prefix?
This should use `--check-prefixes=CHECK,CHECK-FULL` to deduplicate the cases that are the same between full/non-full.


================
Comment at: llvm/test/Transforms/LoopUnroll/revisit.ll:11
 ; Also run in a special mode that visits children.
 ; RUN: opt < %s -disable-output -debug-pass-manager -unroll-revisit-child-loops 2>&1 \
 ; RUN: -passes='require<opt-remark-emit>,loop(loop-unroll-full)' \
----------------
yassingh wrote:
> nikic wrote:
> > yassingh wrote:
> > > How can I add an appropriate test for this option "unroll-revisit-child-loops"? 
> > I think you can just drop the option entirely, it no longer makes sense. We can probably `assert(!IsCurrentLoopValid)` now: Full unrolling should always invalidate the current loop.
> Removed this run line. I  can submit another change to entirely drop this cl option.
That's fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148071/new/

https://reviews.llvm.org/D148071