[PATCH] D117318: [RISCV][GlobalISel] Add lowerReturn for calling conv

[Yueh-Ting (eop) Chen via Phabricator via llvm-commits]

eopXD added inline comments.


================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVCallLowering.cpp:83
+} // namespace
+//
+
----------------
This looks redundant.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:710
 
+private:
   void analyzeInputArgs(MachineFunction &MF, CCState &CCInfo,
----------------
Can we avoid this change?


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:837
+
+namespace RISCV {
+
----------------
Why do we need to promote the static functions into the header here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117318/new/

https://reviews.llvm.org/D117318