[PATCH] D148100: [Assignment Tracking] Fix assertion in AssignmentTrackingPass::runOnFunction

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.
This revision is now accepted and ready to land.

LGTM, with nit



================
Comment at: llvm/lib/IR/DebugInfo.cpp:2031
       assert(llvm::any_of(Markers, [DDI](DbgAssignIntrinsic *DAI) {
-        return DebugVariable(DAI) == DebugVariable(DDI);
+        return DebugVariableAggregate(DAI) == DebugVariableAggregate(DDI);
       }));
----------------
It's worth dropping a comment here indicating why you've used DebugVariableAggregate instead of DebugVariable, to let the reader work out that the fragment can be changed by AT.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148100/new/

https://reviews.llvm.org/D148100