[PATCH] D147715: [ARM] Fix Crashes in fp16/bf16 Inline Asm
Sam Elliott via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 12 03:31:49 PDT 2023
lenary added inline comments.
================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:20357
break;
case 'x':
if (VT == MVT::Other)
----------------
olista01 wrote:
> Should `f16` and `bf16` be allowed for the `x` constraint too?
I'm not sure, so I've asked where the `x` constraint came from. It was introduced in https://reviews.llvm.org/D65863 but `x` is not documented on https://gcc.gnu.org/onlinedocs/gcc/Machine-Constraints.html . The original impetus behind this work was bringing us inline with GCC for `t`: https://github.com/llvm/llvm-project/issues/57753 .
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147715/new/
https://reviews.llvm.org/D147715
More information about the llvm-commits
mailing list