[PATCH] D147975: [StackProtector] don't check stack protector before calling nounwind functions

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/StackProtector.cpp:490
+          // __cxa_throw).
+          if (CB->doesNotReturn() && !CB->doesNotThrow()) {
+            CheckLoc = CB;
----------------
Maybe check `isa<InvokeInst>(CB)` whose semantics (https://llvm.org/docs/LangRef.html#invoke-instruction) define normal control flow and exception control flow. But that may increase the code size for c++ code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147975/new/

https://reviews.llvm.org/D147975