[PATCH] D148077: [RISCV][NFC] Add test case for accept hexadecimal floating-point for fli instructions
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 12 02:22:30 PDT 2023
asb added a comment.
There's obviously a judgement to be made about when you add comprehensive tests vs a sampling and rely on the hex to FP parsing logic to "just work", but I've got no objection to adding these tests. I do think it would be easier to read and more maintainable if you interspersed the hex tests with the existing ones. e.g. put `fli.s ft1, -0x1p+0` and `fli.h ft1, -1.000000e+00` next to each other in the file.
Regarding isa manual changes - if this is going to be documented anyway I'd think the asm manual makes most sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148077/new/
https://reviews.llvm.org/D148077
More information about the llvm-commits
mailing list