[PATCH] D146823: [GVN] Avoid replacing uniforms with non-uniforms in propagateEquality

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 02:00:37 PDT 2023


sameerds added a comment.

In D146823#4245264 <https://reviews.llvm.org/D146823#4245264>, @nikic wrote:

> Compile-time: http://llvm-compile-time-tracker.com/compare.php?from=712dfec1781db8aa92782b98cac5517db548b7f9&to=406639396dd168f459ffb5efcac9eaa1db881f56&stat=instructions:u Would certainly be good if UniformityAnalysis were free for non-GPU targets.

Is this running-time impact a serious enough concern to fix? UniformityAnalysis is special in the sense that it has to be recomputed every time the code changes, at least for now. And it already depends on TTI. So it's not too wrong to just query TTI and immediately return if the target does not have divergence.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146823/new/

https://reviews.llvm.org/D146823



More information about the llvm-commits mailing list