[PATCH] D147931: [ARM] Fix null pointer dereferences in ARMMachObjectWriter::recordRelocation()

Alexey Vishnyakov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 12 01:29:30 PDT 2023


SweetVishnya added a comment.

In D147931#4260122 <https://reviews.llvm.org/D147931#4260122>, @dmgreen wrote:

> I'm not sure A can be null here. Either getSymB will be true (handled above) or isAbsolute will be true. Else A should have a value, if Im reading it correctly.

The bug was reported by a static analyzer because A is checked for null in line 419. But I am not really familiar with the code here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147931/new/

https://reviews.llvm.org/D147931



More information about the llvm-commits mailing list