[PATCH] D147890: Fix sysvhash function

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Please remember to upload your patches with full context.

I'll leave @MaskRay to do the review of the logic, based on his discussion on the gABI list.



================
Comment at: llvm/unittests/Object/ELFTest.cpp:275
+
+// Test the sysV and the gnu hash functions, particularly with utf8 unicode
+TEST(ELFTest, Hash) {
----------------
MaskRay wrote:
> utf8 => UTF-8
Comments should end in a trailing "."


================
Comment at: llvm/unittests/Object/ELFTest.cpp:277-278
+TEST(ELFTest, Hash) {
+  // Symbols long enough to have feedback, we have to explicitly encode the utf8
+  // to avoid encoding transliterations.
+  EXPECT_EQ(hashSysV("FooBarBazToto"), 0x5ec3e8fU);
----------------
I'm not sure what this comment is trying to say. What do you mean by "feedback"? Could you reword it a bit, please?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147890/new/

https://reviews.llvm.org/D147890