[PATCH] D147975: [StackProtector] don't check stack protector before calling nounwind functions

Tue Apr 11 21:42:53 PDT 2023

smeenai added a comment.

In D147975#4259522 <https://reviews.llvm.org/D147975#4259522>, @nickdesaulniers wrote:

> Android undid https://reviews.llvm.org/rGd656ae28095726830f9beb8dbd4d69f5144ef821 here due to measured 2% RSS increase: https://android-review.git.corp.google.com/c/platform/build/soong/+/2524336.  I will add that note to the commit message.  Unless there's more feedback about this change, such as something I may be missing, I plan to commit this tomorrow and request a cherry-pick to the release/16.x branch.

The non-internal version of this link is https://android-review.googlesource.com/c/platform/build/soong/+/2524336. You should update it in the Summary as well.

One other thing to point out here is that we measured D143637 <https://reviews.llvm.org/D143637> internally as having an even larger size increase than D139254 <https://reviews.llvm.org/D139254>. D143637 <https://reviews.llvm.org/D143637>'s been reverted for now, but when it's put up again we probably want a similar check there and/or an option to turn that off as well.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147975/new/

https://reviews.llvm.org/D147975