[PATCH] D145224: [LLVM][OHOS] Use emulated TLS for OHOS platform

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 16:52:03 PDT 2023


MaskRay added a comment.

This patch adds too many RUN lines. I don't think enumerating every combination for your target triple makes good use of the number of RUN lines. Every RUN line adds a small overhead for all users.
I think adding a line to `llvm/test/CodeGen/X86/emutls-pic.ll` testing that emulated TLS is used by default is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145224/new/

https://reviews.llvm.org/D145224



More information about the llvm-commits mailing list