[PATCH] D137707: Move "auto-init" instructions to the dominator of their users

[Alan Zhao via Phabricator via llvm-commits]

ayzhao added a comment.

In D137707#4256648 <https://reviews.llvm.org/D137707#4256648>, @ayzhao wrote:

> In D137707#4253764 <https://reviews.llvm.org/D137707#4253764>, @serge-sans-paille wrote:
>
>> In D137707#4253255 <https://reviews.llvm.org/D137707#4253255>, @ayzhao wrote:
>>
>>> This is also causing another regression in Chrome that is *not* fixed by rGad9ad3735c48 <https://reviews.llvm.org/rGad9ad3735c4821ff4651fab7537a75b8f0bb60f8>: https://crbug.com/1431366#c3
>>
>> Can you provide a minimal reproducer?
>
> Currently working on it, but I'd like to point out that this is also causing another (unrelated?) failure in Chrome/V8: https://crbug.com/1431489

I now have a reproducible (but non-reduced) testcase: https://crbug.com/1431366#c5

This looks like a miscompile; the return parameter is not being initialized if we don't take the branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137707/new/

https://reviews.llvm.org/D137707