[PATCH] D147983: [lld][driver] Add `--relax-gp`/`no-relax-gp` flags for GNU compatibility

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added a comment.

I don't see the issue with landing this change for now , and allowing D143673 <https://reviews.llvm.org/D143673> to revert it when landing. I think that keeps the world in a more consistent state, right? ToT GNU LD accepts the flags, and thus ToT LLD will too.

The other think I'd point out is that I think we //do// need to start setting this option in the clang driver as part of adopting the new platform register for shadow call stack. 
I don't expect that to affect many users, since AFAIK only Fuchsia and Android are looking into using SCS on RISC-V.

The unfortunate fact is that we're in a situation where people  //are// using the latest GNU LD and running into trouble because the compiler doesn't communicate that well to the linker.
They can certainly work around that, but I don't see this as significantly different from setting other linker related options for other sanitizers.

Would you mind elaborating on your views here, and the rationale for why we //wouldn't// want to do that now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147983/new/

https://reviews.llvm.org/D147983