[PATCH] D147865: ValueTracking: Implement computeKnownFPClass for sin/cos

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4442
+        Known.knownNot(fcInf);
+        if (KnownSrc.isKnownNeverInfinity())
+          Known.knownNot(fcNan);
----------------
nikic wrote:
> Doesn't this also require that the src is non-nan as well?
Yes. Annoyingly this applies to every operation


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147865/new/

https://reviews.llvm.org/D147865