[PATCH] D147787: [SLP][NFC]Introduce ShuffleCostEstimator and adjustExtracts member function.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with a few minors



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6905
+    IsFinalized = true;
+      return Cost;
+  }
----------------
formatting


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6918
+  Type *ScalarTy = VL[0]->getType();
+  if (StoreInst *SI = dyn_cast<StoreInst>(VL[0]))
+    ScalarTy = SI->getValueOperand()->getType();
----------------
auto *SI


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6920
+    ScalarTy = SI->getValueOperand()->getType();
+  else if (CmpInst *CI = dyn_cast<CmpInst>(VL[0]))
+    ScalarTy = CI->getOperand(0)->getType();
----------------
auto *CI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147787/new/

https://reviews.llvm.org/D147787