[PATCH] D146988: [CodeGen] Enable processing of interconnected complex number operations

[Nicholas Guy via Phabricator via llvm-commits]

NickGuy added inline comments.


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:921
+    for (User *U : I->users()) {
+      auto *UI = dyn_cast<Instruction>(U);
+      if (AllInstructions.count(UI))
----------------
Nit: If we know for a fact that it's an Instruction, it might be better to use `cast` rather than `dyn_cast`


================
Comment at: llvm/lib/CodeGen/ComplexDeinterleavingPass.cpp:953
+    for (User *U : I->users())
+      Worklist.emplace_back(dyn_cast<Instruction>(U));
+
----------------
As above, `cast` instead of `dyn_cast`


================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-multiuses.ll:4-5
 
 target triple = "aarch64-arm-none-eabi"
 ; Expected to not transform
 ;   *p = (a * b);
----------------
Why is it not? The presence of `fcmla` in the expected output tells me that it is expected to transform


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146988/new/

https://reviews.llvm.org/D146988