[PATCH] D146771: [support] Provide overload to PrintNumber that use C++ types

Paul Kirth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 08:39:56 PDT 2023


paulkirth updated this revision to Diff 512476.
paulkirth marked 7 inline comments as done.
paulkirth added a comment.

Address comments

- update code comments
- add overload for `char`
- add missing test case for `signed char`
- remove `internal` namespace


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146771/new/

https://reviews.llvm.org/D146771

Files:
  llvm/include/llvm/Support/JSON.h
  llvm/include/llvm/Support/ScopedPrinter.h
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/unittests/Support/JSONTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146771.512476.patch
Type: text/x-patch
Size: 8489 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230411/f7191452/attachment.bin>


More information about the llvm-commits mailing list