[PATCH] D147835: [X86][mem-fold] Speed up test by not re-generating the .inc file

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 05:14:10 PDT 2023


thakis added a comment.

In the GN build, the .inc file is at a different path.

As far as I can tell, nothing in this discussion mentions how time this saves – is it a lot?

I suppose we can add a dedicated `%var` for the path to the .inc line?

(Another point: It's generally possible to build LLVM on one machine and copy just built binaries and the test/ folder and then run tests on another machine. This change makes that harder since you now also need to copy over that .inc file.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147835/new/

https://reviews.llvm.org/D147835



More information about the llvm-commits mailing list