[PATCH] D147597: [InstCombine] icmp(X | LHS, C) --> icmp(X, 0)

[Jun Zhang via Phabricator via llvm-commits]

junaire marked an inline comment as done.
junaire added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/icmp.ll:4634
 ; CHECK-NEXT:    [[MUL1:%.*]] = mul i8 [[A:%.*]], [[B:%.*]]
-; CHECK-NEXT:    [[ADD:%.*]] = or i8 [[MUL1]], 24
-; CHECK-NEXT:    [[CMP:%.*]] = icmp sgt i8 [[ADD]], 0
----------------
goldstein.w.n wrote:
> Can you add negative tests where 1) `C` is negative. and 2) where `C >= LHS`.
> 
> 
Hi, I've added negative tests in D147597, do you have more comments? :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147597/new/

https://reviews.llvm.org/D147597