[PATCH] D146438: [RISCV][MC] Refine MCInstrAnalysis based on registers used

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: llvm/unittests/Target/RISCV/MCInstrAnalysisTest.cpp:63
+
+TEST_P(InstrAnalysisTest, IsTerminator) {
+  ASSERT_THAT(Analysis->isTerminator(beq()), IsTrue());
----------------
Nit: I think for most tests in this file you actually want EXPECT_THAT (for which a test failure indicates a non-fatal error), as the following tests still make sense to run even if there was an earlier failure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146438/new/

https://reviews.llvm.org/D146438