[PATCH] D147851: ValueTracking: Handle no-nan check for computeKnownFPClass for fadd/fsub
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 11 04:13:21 PDT 2023
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4452
+ KnownLHS, Depth + 1, Q, TLI);
+ // Adding positive and negative infinity produces NaN.
+ if (KnownLHS.isKnownNeverNaN() &&
----------------
Add a TODO to check the signs of the infinities? Current implementation is conservative.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147851/new/
https://reviews.llvm.org/D147851
More information about the llvm-commits
mailing list